Repository navigation
Conversation
wwbmmm
reviewed
Nov 7, 2026
wwbmmm
left a comment
wwbmmm
left a comment
Contributor
There was a problem hiding this comment.
[replied by brpc-oncall robot] The AVX2 codec matches the scalar modp_b64 semantics for both valid and invalid inputs and the dispatch thresholds look reasonable, but the bundled BSD-2-Clause code is not recorded in the top-level LICENSE, the CPU feature check runs on every call, the first-block comment is inaccurate, and no test reaches the vectorized validation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
Base64 encoding and decoding use scalar implementations on x86 even when AVX2 is available, limiting throughput for medium and large payloads.
What is changed and the side effects?
Changed:
Add an AVX2 Base64 codec derived from aklomp/base64, with BSD-2-Clause attribution.
Dispatch to AVX2 only on supported x86 CPUs.
Use measured thresholds to retain the scalar path for small inputs:
Add unit and fuzz coverage for binary round trips and invalid input.
Add reproducible scalar and AVX2 benchmark targets via BUILD_BASE64_BENCHMARKS.
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: